[Unison-hackers] [unison-svn] r158 - in trunk/src: . uimac/English.lproj/MainMenu.nib

[bcpierce@cis.upenn.edu]

Author: bcpierce
Date: 2006-05-25 00:03:09 -0400 (Thu, 25 May 2006)
New Revision: 158

Modified:
   trunk/src/RECENTNEWS
   trunk/src/files.ml
   trunk/src/mkProjectInfo.ml
   trunk/src/os.ml
   trunk/src/os.mli
   trunk/src/stasher.ml
   trunk/src/uicommon.ml
   trunk/src/uimac/English.lproj/MainMenu.nib/info.nib
   trunk/src/uimac/English.lproj/MainMenu.nib/keyedobjects.nib
   trunk/src/uimac/English.lproj/MainMenu.nib/objects.nib
   trunk/src/uimacbridge.ml
   trunk/src/update.ml
Log:
* Squashed a very insidious bug in the backup mechanism, which turned
  out (after much puzzlement) to occur only when running under the Mac
  GUI.  It seems that the Uimacbridge module includes its own private
  copy of the initialization code from Uicommon (!), and so the
  call to Stasher.initBackups that got added to Uicommon last summer
  was not happening when running with the GUI.  This meant that the
  internal processing of backupprefix and backupsuffix was not
  happening, which meant that multiple backup files were getting
  created with the same names, and this would cause backups to fail
  occasionally (but not always).

  Lesson: Don't duplicate code!!!