From graud at gmx.com  Thu Jul 12 09:44:10 2018
From: graud at gmx.com (G.raud)
Date: Thu, 12 Jul 2018 15:44:10 +0200
Subject: [Unison-hackers] Pull Requests from G.raud awaiting review
Message-ID: <20180712134410.f3glwzjzvb6qgy22@gmx.com>

Hello,

I have made several pull requests still waiting for approval since
march.  To ease the review I list and describe them here.

Several of them are very (very) simple changes that fix bugs or slightly
improve the behavior in a fully backward compatible way (i.e. they
accept the same config files as the older versions and can interact with
older versions as frontend or server).  I think these can be very easily
reviewed and either merged or refused.  The Pull Requests that are
simple fixes that should be merged (or modified then merged):

- #176 Pred: fix detection of empty pathspecs
- #177 Uitext.interact: fix menu documentation
- #179 Uicommon fix: generate ignore patterns not containing Pred.mapSeparator
- #190 Uitext: fix more newline printing and clear infos before failing
  (only the console output is modified)

The Pull Requests that improve the behaviour without changing much and
that should be merged too:

- #181 Pred: parse a single mapSeparator separated by spaces
  (the config file will accept more patterns)
- #184 Ui fix: refuse to choose merge when preference not set
  (in interactive mode sure failures are notified early)
- #191 Uigtk2: improve gtk failure messages
  (only the console output is modified)


The remaining Pull Requests involve some new behavior to be documented
in a release file and some are a bit more complex (but thanks to OCaml
the code is easy to follow).

Extra include directives and options (if the feature is used, older
versions cannot be the frontend) (see
https://github.com/bcpierce00/unison/issues/80#issuecomment-381113502
for a usage example):

- #167 Extra include directives ("source", "include?", "source?")
- #171 Include options for the command line

This can be used to disable or modify merge commands in batch mode
(older versions cannot be the frontend if the feature is employed):

- #175 Merge command string BATCHMODE to detect batch mode
  (if not used fully backward compatible)

Merge preference refinement (discussed in issue #183 and depends on PR
#184) to simply make the verification of mergeability stricter (fully
backward compatible; it simply does not attempt more merges that are
sure to fail).  If PR #178 (Assoc Patterns) is merged too, it makes it
possible to mark paths as mergeable without merging them by default:

- #185 UI: merge selection requires merge command instead of preference

So called Negative, Fixed String and Assoc patterns (backward compatible
but when the new patterns are used, older versions can be neither the
frontend nor the server but there is no risk of data corruption) (see
https://github.com/bcpierce00/unison/issues/80#issuecomment-381113502
for an example using those):

- #155 Negative Patterns in Path Specifications
- #165 Fixed String Pathspec Patterns
- #178 Assoc only Pathspec Patterns

Voil?!

-- 
G.raud

From alan.schmitt at polytechnique.org  Thu Jul 12 10:30:10 2018
From: alan.schmitt at polytechnique.org (Alan Schmitt)
Date: Thu, 12 Jul 2018 16:30:10 +0200
Subject: [Unison-hackers] Pull Requests from G.raud awaiting review
In-Reply-To: <20180712134410.f3glwzjzvb6qgy22@gmx.com> (G. raud's message of
 "Thu, 12 Jul 2018 15:44:10 +0200")
References: <20180712134410.f3glwzjzvb6qgy22@gmx.com>
Message-ID: <m2y3egy1al.fsf@charm.irisa.fr>

Hello,

On 2018-07-12 15:44, "G.raud" <graud at gmx.com> writes:

> I have made several pull requests still waiting for approval since
> march.  To ease the review I list and describe them here.

Thanks a lot. I just submitted a research paper and that was my most
important priority until now. I should have some time next week and
will look at the PR (starting from the easy ones).

Best,

Alan

-- 
OpenPGP Key ID : 040D0A3B4ED2E5C7
Monthly Athmospheric CO?, Mauna Loa Obs. 2018-06: 410.79, 2017-06: 408.84
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 528 bytes
Desc: not available
URL: <http://LISTS.SEAS.UPENN.EDU/pipermail/unison-hackers/attachments/20180712/824ad915/attachment.asc>

From bcpierce at cis.upenn.edu  Sat Jul 14 05:11:19 2018
From: bcpierce at cis.upenn.edu (Benjamin C. Pierce)
Date: Sat, 14 Jul 2018 05:11:19 -0400
Subject: [Unison-hackers] Pull Requests from G.raud awaiting review
In-Reply-To: <m2y3egy1al.fsf@charm.irisa.fr>
References: <20180712134410.f3glwzjzvb6qgy22@gmx.com>
 <m2y3egy1al.fsf@charm.irisa.fr>
Message-ID: <B745F853-FE20-4788-8CCF-637DC41402F3@cis.upenn.edu>

Great!  I?m still in a very busy period ? LICS, POPL deadline, and now the DeepSpec summer school, but I would love to get these vetted and integrated?. 

   - B


> On Jul 12, 2018, at 10:30 AM, Alan Schmitt <alan.schmitt at polytechnique.org> wrote:
> 
> Hello,
> 
> On 2018-07-12 15:44, "G.raud" <graud at gmx.com> writes:
> 
>> I have made several pull requests still waiting for approval since
>> march.  To ease the review I list and describe them here.
> 
> Thanks a lot. I just submitted a research paper and that was my most
> important priority until now. I should have some time next week and
> will look at the PR (starting from the easy ones).
> 
> Best,
> 
> Alan
> 
> -- 
> OpenPGP Key ID : 040D0A3B4ED2E5C7
> Monthly Athmospheric CO?, Mauna Loa Obs. 2018-06: 410.79, 2017-06: 408.84
> _______________________________________________
> Unison-hackers mailing list
> Unison-hackers at LISTS.SEAS.UPENN.EDU
> https://LISTS.SEAS.UPENN.EDU/mailman/listinfo/unison-hackers


From alan.schmitt at polytechnique.org  Thu Jul 19 03:18:10 2018
From: alan.schmitt at polytechnique.org (Alan Schmitt)
Date: Thu, 19 Jul 2018 09:18:10 +0200
Subject: [Unison-hackers] Pull Requests from G.raud awaiting review
In-Reply-To: <20180712134410.f3glwzjzvb6qgy22@gmx.com> (G. raud's message of
 "Thu, 12 Jul 2018 15:44:10 +0200")
References: <20180712134410.f3glwzjzvb6qgy22@gmx.com>
Message-ID: <m2601bn171.fsf@charm.irisa.fr>

Hello,

On 2018-07-12 15:44, "G.raud" <graud at gmx.com> writes:

> - #176 Pred: fix detection of empty pathspecs
> - #177 Uitext.interact: fix menu documentation
> - #179 Uicommon fix: generate ignore patterns not containing Pred.mapSeparator
> - #190 Uitext: fix more newline printing and clear infos before failing
>   (only the console output is modified)

I've reviewed all these and they can be merged.

> The Pull Requests that improve the behaviour without changing much and
> that should be merged too:
>
> - #181 Pred: parse a single mapSeparator separated by spaces
>   (the config file will accept more patterns)

I've added a comment to this one, but I think it's almost ready to be
merged.

This is all the time I have for now, I'll try to do more next week.

Best,

Alan

-- 
OpenPGP Key ID : 040D0A3B4ED2E5C7
Monthly Athmospheric CO?, Mauna Loa Obs. 2018-06: 410.79, 2017-06: 408.84
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 528 bytes
Desc: not available
URL: <http://LISTS.SEAS.UPENN.EDU/pipermail/unison-hackers/attachments/20180719/94d20756/attachment.asc>