From reactorcontrol at icloud.com Thu Jan 10 08:09:59 2019 From: reactorcontrol at icloud.com (Michael Roitzsch) Date: Thu, 10 Jan 2019 14:09:59 +0100 Subject: [Unison-hackers] Update and cleanup plan for the macOS UI Message-ID: <4A8D6701-6AD2-4C18-A761-D2C3D4917762@icloud.com> Hi Unison devs, As I mentioned in my pull request for supporting macOS Mojave?s dark mode (https://github.com/bcpierce00/unison/pull/236), I would like to invest some work in the macOS UI. But before I begin, I want to clarify what changes I have in mind and discuss if you feel they are acceptable. I do not want to change much in the way the UI works. I am quite used to it and I think it works well the way it is. I also do not want to upgrade the minimum deployment target beyond the current 10.6 unless necessary for some important feature. I would ask back here, if that becomes an issue. I also do not plan on introducing any new dependencies. I would propose the following updates and cleanups: * cleanup the build system, including the Xcode project (newer Xcode shows warnings there) * cleanup the code formatting (I see some mixture between tabs and spaces) * fix warnings (and deprecations, as far as possible within the 10.6 target) * replace the hardcoded colors to be better suited for dark mode * upgrade all artwork for dark mode and high DPI (?Retina?) support * enable Cmd-C (copy) to copy the path when a file is selected * maybe add a contextual menu to provide quick access to some actions (diff, ignore, reveal in Finder) Two questions I have: * Would it be OK to rename the folder from uimac14 to just uimac? Since this is the one and only macOS UI, the extra 14 seems confusing. * What do think about localization? Is it too much effort to maintain in the future? Otherwise, I might also consider a German localization. If this proposal is welcome, I would work on this in the coming weeks. I don?t want to make any projections for when I will be finished, though. My progress will be visible in my fork on GitHub: https://github.com/mroi/unison (I will take the liberty of reordering commits or rebasing against upstream at any time, so do not expect fast-forward updates.) Regards, Michael PS: Finally, I should thank you for this great tool. I heavily use Unison as part of my daily routine and it has easily helped me keep my sanity when working across multiple machines. From bcpierce at cis.upenn.edu Fri Jan 11 20:05:19 2019 From: bcpierce at cis.upenn.edu (Benjamin C. Pierce) Date: Fri, 11 Jan 2019 20:05:19 -0500 Subject: [Unison-hackers] Update and cleanup plan for the macOS UI In-Reply-To: <4A8D6701-6AD2-4C18-A761-D2C3D4917762@icloud.com> References: <4A8D6701-6AD2-4C18-A761-D2C3D4917762@icloud.com> Message-ID: <8AB5AA48-A9C1-4311-BFBE-E14FC207FC8E@cis.upenn.edu> Dear Michael, All these changes should be very welcome. To your questions: > * Would it be OK to rename the folder from uimac14 to just uimac? Since this is the one and only macOS UI, the extra 14 seems confusing. Yes, this rename is overdue. > * What do think about localization? Is it too much effort to maintain in the future? Otherwise, I might also consider a German localization. We?ve considered localization in the past, but the hesitation has indeed been that it might be hard to maintain (and, relatedly, might make a lot of the code quite a bit uglier). > If this proposal is welcome, I would work on this in the coming weeks. I don?t want to make any projections for when I will be finished, though. My progress will be visible in my fork on GitHub: https://github.com/mroi/unison (I will take the liberty of reordering commits or rebasing against upstream at any time, so do not expect fast-forward updates.) Thanks very much for your efforts (to come)! > PS: Finally, I should thank you for this great tool. I heavily use Unison as part of my daily routine and it has easily helped me keep my sanity when working across multiple machines. You?re welcome! Best, - Benjamin From bcpierce at cis.upenn.edu Fri Jan 11 20:12:23 2019 From: bcpierce at cis.upenn.edu (Benjamin C. Pierce) Date: Fri, 11 Jan 2019 20:12:23 -0500 Subject: [Unison-hackers] Update and cleanup plan for the macOS UI In-Reply-To: <8AB5AA48-A9C1-4311-BFBE-E14FC207FC8E@cis.upenn.edu> References: <4A8D6701-6AD2-4C18-A761-D2C3D4917762@icloud.com> <8AB5AA48-A9C1-4311-BFBE-E14FC207FC8E@cis.upenn.edu> Message-ID: > All these changes should be very welcome. P.S. To avoid proposed changes taking unreasonably long to review, it?s probably a good idea to generate several PRs incrementally? - B > To your questions: > >> * Would it be OK to rename the folder from uimac14 to just uimac? Since this is the one and only macOS UI, the extra 14 seems confusing. > > Yes, this rename is overdue. > >> * What do think about localization? Is it too much effort to maintain in the future? Otherwise, I might also consider a German localization. > > We?ve considered localization in the past, but the hesitation has indeed been that it might be hard to maintain (and, relatedly, might make a lot of the code quite a bit uglier). > >> If this proposal is welcome, I would work on this in the coming weeks. I don?t want to make any projections for when I will be finished, though. My progress will be visible in my fork on GitHub: https://github.com/mroi/unison (I will take the liberty of reordering commits or rebasing against upstream at any time, so do not expect fast-forward updates.) > > Thanks very much for your efforts (to come)! > >> PS: Finally, I should thank you for this great tool. I heavily use Unison as part of my daily routine and it has easily helped me keep my sanity when working across multiple machines. > > You?re welcome! > > Best, > > - Benjamin > > > _______________________________________________ > Unison-hackers mailing list > Unison-hackers at LISTS.SEAS.UPENN.EDU > https://LISTS.SEAS.UPENN.EDU/mailman/listinfo/unison-hackers > From reactorcontrol at icloud.com Sat Jan 12 14:12:03 2019 From: reactorcontrol at icloud.com (Michael Roitzsch) Date: Sat, 12 Jan 2019 20:12:03 +0100 Subject: [Unison-hackers] Update and cleanup plan for the macOS UI In-Reply-To: <8AB5AA48-A9C1-4311-BFBE-E14FC207FC8E@cis.upenn.edu> References: <4A8D6701-6AD2-4C18-A761-D2C3D4917762@icloud.com> <8AB5AA48-A9C1-4311-BFBE-E14FC207FC8E@cis.upenn.edu> Message-ID: <3B2F33D0-0ED6-4759-A917-21B69D90C46D@icloud.com> Hi Benjamin, > All these changes should be very welcome. Good, I?ll get to it then. >> * What do think about localization? Is it too much effort to maintain in the future? Otherwise, I might also consider a German localization. > > We?ve considered localization in the past, but the hesitation has indeed been that it might be hard to maintain (and, relatedly, might make a lot of the code quite a bit uglier). Got it. I?ll not go there. Thanks also for the advice of packaging as multiple PRs. Michael