[Unison-hackers] call for review and testing: ACLs and extended attributes
Greg Troxel
gdt at lexort.com
Fri Jul 22 14:05:19 EDT 2022
I have just been merging things without real review when some
conditions are met:
- successful CI (including old-version regression)
- I understand the high-level approach of the change
- I have skimmed it
- The submitter has a track record of a very low rate of breakage in
recent history of merged PRs
- it doesn't seem super complicated
There are two PRs that are on the more complicated side and I would like
help with code review and testing. (I haven't skimmed yet, but will.)
See the notes; running this will upgrade archives to a form that can't
be used by the tip of master, but I am pretty sure you can use it on
test roots only with no trouble. (My approach when doing any kind of
upgrade is to make sure everything is 100% synced before changing
anything; then archives can just be deleted and regenerated.)
ACL: https://github.com/bcpierce00/unison/pull/359
xattr: https://github.com/bcpierce00/unison/pull/368
(Also note that there are test commits that won't get merged.)
I am unclear if these use the same archive-format extension and how it
works if you run both. Maybe Töivo can comment?
Testing on other than the triculture (like a monoculture, but with 3 :-)
is especially welcome.
I intend to test them myself, which may lead to a subroutine call to
grasp ACLs and xattr, which are newfangled to me and something I don't
tend to use (although clearly useful), and if by the time that happens,
there are no comments, I'm going to merge anyway.
Thanks,
Greg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 194 bytes
Desc: not available
URL: <http://LISTS.SEAS.UPENN.EDU/pipermail/unison-hackers/attachments/20220722/a903608f/attachment.asc>
More information about the Unison-hackers
mailing list