[Unison-hackers] updated mac frontend (2.27)

[Benjamin Pierce]

Hi Onne,

I'd be happy to incorporate this change, but I'm not confident I  
understand what needs to be done to the .xib file...

    - B


On Sep 29, 2009, at 4:49 AM, Onne Gorter wrote:

> Hi,
>
> my father in law uses unison, and a while back I updated the mac
> frontend (2.27) to behave a bit nicer:
> * when you close the app, it now quits unison, instead of leaving an
> empty icon which won't do anything anymore
> * fix a bug in the cell renderer usage, clicking in the progress
> columns will corrupt memory and eventually crash the app
>
> (Every column uses one cell renderer, not a cell renderer per cell, so
> you should not retain and release images, especially not on dealloc,
> which will do an extra release of the last image; but honestly, I
> don't know the implied usage of a cell renderer, and the documentation
> doesn't really mention any of this. But it does fix the crash, and
> does not introduce a leak.)
>
> I've mirrored the (then) stable release on github, after upgrading the
> mac project to xcode 3 and xib format, this is the commit that fixes
> things:
> http://github.com/onnlucky/unison/commit/cc3840d2ee0e1d62dc8193e882b1b6863fa60c89
>
> unfortunately, as xcode goes, the diff of the xib is rather useless,
> the rest should be legible ...
>
>
> I guess I should redo the work for the new stable, which at least has
> already upgraded its xcode stuff, but as things go, I'll do that just
> in time (when upgrading my in laws setup), if nobody beat me to it ...
>
> thanks for the great app,
>
> -regards,
> Onne
> _______________________________________________
> Unison-hackers mailing list
> Unison-hackers at lists.seas.upenn.edu
> http://lists.seas.upenn.edu/mailman/listinfo/unison-hackers